From a2f7834ef5820c55ca61d0d5c94832b96dac4ebf Mon Sep 17 00:00:00 2001 From: Anthony Birkett Date: Sun, 30 May 2021 11:30:29 +0100 Subject: [PATCH] Use autoloading. --- Examples/Example.php | 2 +- Examples/RconExample.php | 2 +- Examples/View.php | 4 +++- SourceQuery/BaseSocket.php | 2 +- SourceQuery/Socket.php | 12 +++++++++--- SourceQuery/bootstrap.php | 30 ------------------------------ Tests/phpunit.xml | 4 +--- composer.json | 6 +++--- 8 files changed, 19 insertions(+), 43 deletions(-) delete mode 100644 SourceQuery/bootstrap.php diff --git a/Examples/Example.php b/Examples/Example.php index a8bc770..cfa061d 100644 --- a/Examples/Example.php +++ b/Examples/Example.php @@ -2,7 +2,7 @@ declare(strict_types=1); -require __DIR__ . '/../SourceQuery/bootstrap.php'; +require __DIR__ . '/../vendor/autoload.php'; use xPaw\SourceQuery\SourceQuery; diff --git a/Examples/RconExample.php b/Examples/RconExample.php index d1e22de..dc58692 100644 --- a/Examples/RconExample.php +++ b/Examples/RconExample.php @@ -2,7 +2,7 @@ declare(strict_types=1); -require __DIR__ . '/../SourceQuery/bootstrap.php'; +require __DIR__ . '/../vendor/autoload.php'; use xPaw\SourceQuery\SourceQuery; diff --git a/Examples/View.php b/Examples/View.php index 9ecaa47..49d798c 100644 --- a/Examples/View.php +++ b/Examples/View.php @@ -2,7 +2,7 @@ declare(strict_types=1); -require __DIR__ . '/../SourceQuery/bootstrap.php'; +require __DIR__ . '/../vendor/autoload.php'; use xPaw\SourceQuery\SourceQuery; @@ -115,6 +115,8 @@ $Timer = number_format(microtime(true) - $Timer, 4, '.', ''); echo 'true'; } elseif ($InfoValue === false) { echo 'false'; + } elseif (is_int($InfoValue)) { + echo $InfoValue; } else { echo htmlspecialchars($InfoValue); } diff --git a/SourceQuery/BaseSocket.php b/SourceQuery/BaseSocket.php index f1a98dc..3cae434 100644 --- a/SourceQuery/BaseSocket.php +++ b/SourceQuery/BaseSocket.php @@ -29,7 +29,7 @@ use xPaw\SourceQuery\Exception\SocketException; abstract class BaseSocket { /** - * @var resource + * @var resource|null */ public $Socket; diff --git a/SourceQuery/Socket.php b/SourceQuery/Socket.php index 05489e3..6735e74 100644 --- a/SourceQuery/Socket.php +++ b/SourceQuery/Socket.php @@ -33,10 +33,10 @@ final class Socket extends BaseSocket */ public function Close(): void { - if ($this->Socket !== null) { + if ($this->Socket !== null && $this->Socket !== 0) { fclose($this->Socket); - $this->Socket = 0; + $this->Socket = null; } } @@ -94,7 +94,13 @@ final class Socket extends BaseSocket public function Read(int $Length = 1400): Buffer { $Buffer = new Buffer(); - $Buffer->Set(fread($this->Socket, $Length)); + $data = fread($this->Socket, $Length); + + if (!$data) { + throw new SocketException('Failed to open socket.'); + } + + $Buffer->Set($data); $this->ReadInternal($Buffer, $Length, [ $this, 'Sherlock' ]); diff --git a/SourceQuery/bootstrap.php b/SourceQuery/bootstrap.php deleted file mode 100644 index c11049e..0000000 --- a/SourceQuery/bootstrap.php +++ /dev/null @@ -1,30 +0,0 @@ - - + ./Tests.php diff --git a/composer.json b/composer.json index 7913280..3f8d3ec 100644 --- a/composer.json +++ b/composer.json @@ -19,9 +19,9 @@ "require": { "php": ">=7.4", - "ext-bz2": ">7.*", - "ext-gmp": ">7.*", - "ext-json": ">7.*" + "ext-bz2": ">=7.4", + "ext-gmp": ">=7.4", + "ext-json": ">=7.4" }, "require-dev": {